Skip to content

Use pymatgen-core for symmetry - #45

Merged
galjos merged 1 commit into
mainfrom
reduce-pymatgen-dependency
Jun 23, 2026
Merged

Use pymatgen-core for symmetry#45
galjos merged 1 commit into
mainfrom
reduce-pymatgen-dependency

Conversation

@galjos

@galjos galjos commented Jun 23, 2026

Copy link
Copy Markdown
Member

Summary

  • Replace the full pymatgen dependency with pymatgen-core >= 2026.5.18.
  • Handle monoatomic and overlapping atom symmetry cases.
  • Add symmetry edge-case regression coverage.

Validation

  • python -m pytest -q
  • Clean install with pymatgen-core only

@galjos
galjos merged commit 445d9ac into main Jun 23, 2026
1 check passed
@galjos
galjos deleted the reduce-pymatgen-dependency branch June 23, 2026 07:01
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.78%. Comparing base (22ab27f) to head (2d6e8b1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   93.54%   93.78%   +0.23%     
==========================================
  Files          21       21              
  Lines        1178     1190      +12     
==========================================
+ Hits         1102     1116      +14     
+ Misses         76       74       -2     
Flag Coverage Δ
unittests 93.78% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant