Skip to content

Avoid symmetry complex-cast warnings - #43

Merged
galjos merged 1 commit into
mainfrom
fix-symmetry-coordinate-warnings
Jun 22, 2026
Merged

Avoid symmetry complex-cast warnings#43
galjos merged 1 commit into
mainfrom
fix-symmetry-coordinate-warnings

Conversation

@galjos

@galjos galjos commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

  • convert symmetry-analysis coordinates to real floats before creating pymatgen molecules
  • suppress the known benign pymatgen operations ComplexWarning inside point-group analysis
  • reject atom positions with meaningful imaginary components
  • add regression coverage for zero-imaginary and near-zero-imaginary positions

Validation

  • python -m pytest tests/thermo/test_system.py -q
  • python -m pytest -q
  • python -m pytest --cov=ThermoScreening --cov-report=term-missing -q (94%)
  • python -m pylint ThermoScreening
  • Linux DFTB+ water thermochemistry with ComplexWarning treated as error

Closes #42

@galjos
galjos force-pushed the fix-symmetry-coordinate-warnings branch from c0c2e9d to 6705451 Compare June 22, 2026 21:06
@galjos
galjos merged commit 90789ff into main Jun 22, 2026
1 check passed
@galjos
galjos deleted the fix-symmetry-coordinate-warnings branch June 22, 2026 21:08
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.54%. Comparing base (2af48d0) to head (6705451).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   93.49%   93.54%   +0.05%     
==========================================
  Files          21       21              
  Lines        1168     1178      +10     
==========================================
+ Hits         1092     1102      +10     
  Misses         76       76              
Flag Coverage Δ
unittests 93.54% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid pymatgen complex-cast warnings during symmetry analysis

1 participant