Skip to content

Improve README and externalize DFTB parameters - #39

Merged
galjos merged 1 commit into
mainfrom
improve-readme-coverage-and-slakos
Jun 22, 2026
Merged

Improve README and externalize DFTB parameters#39
galjos merged 1 commit into
mainfrom
improve-readme-coverage-and-slakos

Conversation

@galjos

@galjos galjos commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

  • rewrite the README and move roadmap TODOs into issues
  • require DFTB_PREFIX or slako_dir for Slater-Koster files
  • remove bundled 3ob-3-1 parameter files and add pure unit coverage

Validation

  • python -m pytest -q
  • python -m pytest --cov=ThermoScreening --cov-report=term-missing -q (93%)
  • python -m pylint ThermoScreening
  • python -m pip wheel . --no-deps -w /tmp/thermoscreening-wheel-test

Follow-up issues: #29, #30, #32-#38

Closes #31

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.85%. Comparing base (b93b275) to head (9924dd2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   89.94%   92.85%   +2.91%     
==========================================
  Files          20       20              
  Lines        1074     1064      -10     
==========================================
+ Hits          966      988      +22     
+ Misses        108       76      -32     
Flag Coverage Δ
unittests 92.85% <100.00%> (+2.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@galjos
galjos marked this pull request as ready for review June 22, 2026 20:08
@galjos
galjos merged commit 4ed5990 into main Jun 22, 2026
3 checks passed
@galjos
galjos deleted the improve-readme-coverage-and-slakos branch June 22, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand regression and integration test coverage

1 participant