Note the QM readers are tested against real program output - #113
Merged
Conversation
Add a brief docs note to the QM-import usage section: orca_thermo and cclib_thermo are now validated against genuine ORCA 6.1.1, Gaussian 16 and Turbomole 7.2 output (not just synthetic fixtures), and unparseable files raise TSValueError rather than an arbitrary exception from the underlying parser.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
=======================================
Coverage 97.29% 97.29%
=======================================
Files 31 31
Lines 1921 1921
=======================================
Hits 1869 1869
Misses 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small docs-only addition following the ORCA/Gaussian/Turbomole real-software validation work (#108, #110, #112): a brief note in the QM-import usage section stating that
orca_thermo/cclib_thermoare validated against genuine program output, and that unparseable files raiseTSValueErrorrather than an arbitrary parser exception.Verified by building the docs locally and visually checking the rendered note (Furo's styled admonition) in the browser. No code changes.