Skip to content

feat: use timerId instead of raw strings for timer identification - #500

Open
97gamjak wants to merge 6 commits into
devfrom
use-timer-ids
Open

feat: use timerId instead of raw strings for timer identification#500
97gamjak wants to merge 6 commits into
devfrom
use-timer-ids

Conversation

@97gamjak

Copy link
Copy Markdown
Collaborator

No description provided.

@pq-perf-bot

pq-perf-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

⚡ Performance (instruction count) — ✅ no regressions

per-benchmark breakdown
benchmark base Ir PR Ir Δ
bondedForces 38.24M 38.24M -0.00%
boxTransforms 10.67M 10.67M +0.00%
constraints 10.91M 10.94M +0.22%
coulombKernel 5.80M 5.80M +0.00%
forceKernel 14.16M 14.16M -0.00%
integrator 32.44M 32.44M +0.00%
interWater 1681.40M 1681.40M +0.00%
kinetics 8.55M 8.55M +0.00%
linearAlgebra 2.08M 2.08M +0.00%
nonCoulombPairs 5.48M 5.48M +0.00%
shiftVector 5.81M 5.81M +0.00%
virial 10.44M 10.44M +0.00%

Deterministic callgrind instruction counts vs the base branch; gated at ±2%. Not wall-clock.

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.01%. Comparing base (f5667ee) to head (66b01eb).

Files with missing lines Patch % Lines
src/timings/timerId.cpp 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #500      +/-   ##
==========================================
- Coverage   91.02%   91.01%   -0.02%     
==========================================
  Files         320      322       +2     
  Lines       14563    14574      +11     
  Branches     4825     4831       +6     
==========================================
+ Hits        13256    13264       +8     
- Misses       1221     1227       +6     
+ Partials       86       83       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant