Skip to content

Feat/hybrid center xyz file - #496

Merged
ape33 merged 5 commits into
devfrom
feat/hybrid-center-xyz-file
Aug 13, 2026
Merged

Feat/hybrid center xyz file#496
ape33 merged 5 commits into
devfrom
feat/hybrid-center-xyz-file

Conversation

@ape33

@ape33 ape33 commented Aug 12, 2026

Copy link
Copy Markdown
Member

This PR solves issue #467

@ape33
ape33 requested a review from 97gamjak August 12, 2026 10:51
@ape33 ape33 added the new feature New feature or request label Aug 12, 2026
@ape33 ape33 linked an issue Aug 12, 2026 that may be closed by this pull request
@pq-perf-bot

pq-perf-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

⚡ Performance (instruction count) — ✅ no regressions

per-benchmark breakdown
benchmark base Ir PR Ir Δ
bondedForces 38.24M 38.25M +0.00%
boxTransforms 10.67M 10.67M +0.00%
constraints 10.91M 10.91M +0.00%
coulombKernel 5.80M 5.80M +0.00%
forceKernel 14.16M 14.16M +0.00%
integrator 32.44M 32.44M +0.00%
interWater 1681.40M 1681.40M +0.00%
kinetics 8.55M 8.55M +0.00%
linearAlgebra 2.08M 2.08M +0.00%
nonCoulombPairs 5.48M 5.48M +0.00%
shiftVector 5.81M 5.81M +0.01%
virial 10.44M 10.44M +0.00%

Deterministic callgrind instruction counts vs the base branch; gated at ±2%. Not wall-clock.

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.04%. Comparing base (298c4bb) to head (4920f2c).
⚠️ Report is 9 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #496      +/-   ##
==========================================
- Coverage   91.13%   91.04%   -0.09%     
==========================================
  Files         319      321       +2     
  Lines       14540    14599      +59     
  Branches     4820     4839      +19     
==========================================
+ Hits        13251    13292      +41     
- Misses       1203     1221      +18     
  Partials       86       86              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/engine/engineOutput.cpp
Comment thread src/output/trajectoryOutput.cpp
@ape33
ape33 merged commit 6ccb5d3 into dev Aug 13, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write Inner Region Center to Separate .xyz File

3 participants