Harden external-QM execution - #384
Open
galjos wants to merge 10 commits into
Open
Conversation
This was referenced Jul 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #384 +/- ##
==========================================
+ Coverage 90.07% 90.13% +0.05%
==========================================
Files 291 291
Lines 11845 11855 +10
Branches 3755 3761 +6
==========================================
+ Hits 10669 10685 +16
+ Misses 1132 1126 -6
Partials 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
⚡ Performance (instruction count) — ✅ no regressionsper-benchmark breakdown
Deterministic callgrind instruction counts vs the base branch; gated at ±2%. Not wall-clock. |
Member
|
In principal a nice addition, but I have been working on the external QM runners in the qmmm-dev branch and dread the inevitable merge conflicts that will arise. Could we re-do this after merging the qmmm-dev into dev. I guess it is easier and less error-prone for the AI to re-do the changes than me resolving merge conflicts... |
97gamjak
previously approved these changes
Aug 1, 2026
galjos
marked this pull request as draft
August 1, 2026 20:44
galjos
marked this pull request as ready for review
August 5, 2026 19:11
github-actions
Bot
dismissed
97gamjak’s stale review
August 6, 2026 08:07
Approval dismissed: new commits contain changes beyond a merge-up from dev.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External-QM runs now reject failed processes and incomplete result files. Executable and working-directory paths are quoted, including paths with spaces.
Validated by
testExternalQMRunnerandtestStringUtilities.Closes #381.