Skip to content

fix: define parameter reader destructor out of line #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
97gamjak merged 3 commits into from
Aug 1, 2026
Merged

fix: define parameter reader destructor out of line #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03dfff9
fix: define parameter reader destructor out of line
galjos Jul 28, 2026
f35b57c
merge: update from dev
galjos Jul 30, 2026
3a1c003
chore: add required changelog fragment
galjos Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/parameter-reader-destructor.developer.bugfix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Define `ParameterFileReader` destruction where `ParameterFileSection` is complete so AppleClang builds succeed.
3 changes: 2 additions & 1 deletion include/input/parameterFileReader/parameterFileReader.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ namespace input::parameterFile

public:
ParameterFileReader(const std::string &filename, pq::Engine &engine);
~ParameterFileReader();

void read();
void deleteSection(const pq::ParamFileSection *section);
Expand All @@ -72,4 +73,4 @@ namespace input::parameterFile

} // namespace input::parameterFile

#endif // _PARAMETER_FILE_READER_HPP_
#endif // _PARAMETER_FILE_READER_HPP_
4 changes: 3 additions & 1 deletion src/input/parameterFileReader/parameterFileReader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ ParameterFileReader::ParameterFileReader(
_parameterFileSections.push_back(make_unique<NonCoulombicsSection>());
}

ParameterFileReader::~ParameterFileReader() = default;

/**
* @brief determines which section of the parameter file the header line belongs
* to
Expand Down Expand Up @@ -219,4 +221,4 @@ std::vector<std::unique_ptr<ParameterFileSection>> &ParameterFileReader::
const std::string &ParameterFileReader::getFilename() const
{
return _fileName;
}
}
Loading