Repository navigation
fix(ui): taps place the caret where the finger is, also in RTL - #23
Merged
Merged
Conversation
- hit test: the extent of a right-to-left row (and of a structure in the root row) was taken backwards, so taps inside fractions / roots / scripts and Arabic text next to a structure went to the wrong row - tap: the browser's touch-adjusted mouse position (snapped to a nearby clickable) is replaced by the finger's own pointer position, which moved the caret one stop away near the ends of a line - tools: probe_rtl_touch (taps every stop of every row, LTR and RTL) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hit testing treated the extent of right-to-left rows backwards (taps inside fractions, roots, scripts and Arabic text next to a structure went to the wrong row), and the touch-adjusted mouse position of the browser moved the caret one stop away near line ends. Taps now use the finger's pointer position; extents use min/max.
Verified on a 390x844 touch viewport: tools/probe_rtl_touch.cjs, probe_caret_tap, probe_caret_long, probe_longpress_select; tests 554/554.
🤖 Generated with Claude Code