test(gq): add the Kuzu-derived .gqt case corpus - #617
Open
azimafroozeh wants to merge 1 commit into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
97
kuzu_*.gqtfeature cases (275 steps) translated from the Kuzu e2e tests (test/test_files/, MIT): regression coverage for match patterns,where,not { }, bounded traversal, return, order, limit, and the aggregates. Follow-up to #607. No harness change.WITH, path variables, functions, multi-label patterns) and 278 were skipped (large datasets, Kuzu-SKIP); they are absent, not red.{m,n}is shortest-path distance per endpoint pair, an undirected self-loop is one row,AVGat scale 12.crates/omnigraph-gqt/README.mdgains the derived-case rules and the MIT notice; RFC 0045's Decision log records the source-prefix convention. The fix-regression gate keys on theissue_prefix and never reads these files.Backing issue / RFC
docs/rfcs/0045-gq-logic-tests.md, draft): Decision log amended with the derived-case rules; nothing here differs from its design.Checklist
Local verification
cargo test -p omnigraph-gqt: 94 unit tests green; corpus 96 passed / 10 failed (the red-on-purpose set); slowest case 0.72 s.limitsteps that were green only by scan order, and five dropped reads.python3 scripts/check-docs.py: ok. Vocabulary guard, fmt, clippy: not run, no Rust or guarded surface in the diff.Notes for reviewers
# notes: Red on purpose:line naming what it waits on.GQ Logic Testsis a required check, so this stays a draft; each fix PR carries its own minimalissue_N_case and these remain as full-seed coverage:sumover an integer column accumulates inf64(1 file)T25refusal not yet in the compiler (2 files)F32cells render as thef64widening,0.99as0.990000009537(4 files)min/maxoverBoolandDaterefused,T8(2 files)count($e)over an edge binding refused,T23(1 file)