Skip to content

Update frontend.php - fix for moodle 4.5 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rieckt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update frontend.php - fix for moodle 4.5 #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 54 additions & 20 deletions classes/frontend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.

/**
* Front-end class.
* Front-end class for the other course completion availability condition.
*
* @package availability_othercompleted
* @copyright MU DOT MY PLT <support@mu.my>
Expand All @@ -24,25 +24,51 @@

namespace availability_othercompleted;

defined('MOODLE_INTERNAL') || die();

/**
* Front-end class for the other course completion availability condition.
*
* @package availability_othercompleted
* @copyright MU DOT MY PLT <support@mu.my>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class frontend extends \core_availability\frontend {
/**
* @var array Cached init parameters
*/
protected $cacheparams = array();
protected $cacheparams = [];

/**
* @var string IDs of course, cm, and section for cache (if any)
*/
protected $cachekey = '';

/**
* @var array Cache for the initialization parameters
*/
protected $cacheinitparams = [];

/**
* Gets a list of JavaScript strings required for this module.
*
* @return array Array of required string identifiers
*/
protected function get_javascript_strings() {
return array('option_complete', 'label_cm', 'label_completion');
return ['option_complete', 'label_cm', 'label_completion'];
}

protected function get_javascript_init_params($course, \cm_info $cm = null,
\section_info $section = null) {
/**
* Gets parameters for the JavaScript init function.
*
* @param \stdClass $course The course object
* @param ?\cm_info $cm Course module info object (optional)
* @param ?\section_info $section Section info object (optional)
* @return array Array of parameters for the JavaScript function
*/
protected function get_javascript_init_params(
$course,
?\cm_info $cm = null,
?\section_info $section = null
) {
// Use cached result if available. The cache is just because we call it
// twice (once from allow_add) so it's nice to avoid doing all the
// print_string calls twice.
Expand All @@ -51,31 +77,39 @@ protected function get_javascript_init_params($course, \cm_info $cm = null,
// Get list of activities on course which have completion values,
// to fill the dropdown.
$context = \context_course::instance($course->id);
// get all course name
$datcms = array();
$datcms = [];
global $DB;
$sql2 = "SELECT * FROM {course}
$sql2 = "SELECT * FROM {course}
ORDER BY fullname ASC";
$other = $DB->get_records_sql($sql2);
// $other = get_courses();
foreach ($other as $othercm) {
// disable not created course and default course
if(($othercm->category > 0) && ($othercm->id != $course->id)){
$datcms[] = (object)array(
// Disable not created course and default course.
if (($othercm->category > 0) && ($othercm->id != $course->id)) {
$datcms[] = (object)[
'id' => $othercm->id,
'name' => format_string($othercm->fullname, true, array('context' => $context))
// 'completiongradeitemnumber' => $othercm->completiongradeitemnumber
);
'name' => format_string($othercm->fullname, true, ['context' => $context]),
];
}
}
$this->cachekey = $cachekey;
$this->cacheinitparams = array($datcms);
$this->cacheinitparams = [$datcms];
}
return $this->cacheinitparams;
}

protected function allow_add($course, \cm_info $cm = null,
\section_info $section = null) {
/**
* Determines whether this availability condition can be added to a course/module.
*
* @param \stdClass $course The course object
* @param ?\cm_info $cm Course module info object (optional)
* @param ?\section_info $section Section info object (optional)
* @return bool True if this condition can be added, false otherwise
*/
protected function allow_add(
$course,
?\cm_info $cm = null,
?\section_info $section = null
) {
global $CFG;

// Check if completion is enabled for the course.
Expand Down