Skip to content

Stabilize Garnet Lua integration timeout#371

Open
ModerRAS wants to merge 1 commit into
masterfrom
fix/release-garnet-lua-timeout
Open

Stabilize Garnet Lua integration timeout#371
ModerRAS wants to merge 1 commit into
masterfrom
fix/release-garnet-lua-timeout

Conversation

@ModerRAS

@ModerRAS ModerRAS commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • increase the embedded Garnet integration test command timeout from 2 seconds to 15 seconds
  • keep the test enabled in release validation
  • leave production Redis settings unchanged

Root cause

Release run 30183476870 reached the embedded Garnet server but a SETEX command took about 6.2 seconds on the hosted Windows runner and exceeded the test client 2-second timeout.

Validation

  • targeted Garnet Lua integration test passed
  • Release solution build passed
  • full Category!=Performance Release test selection passed

Summary by CodeRabbit

  • Tests
    • Increased connection timeout thresholds for embedded service integration tests, improving reliability during slower startup or connection conditions.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d80d46c3-9e00-4958-9215-9974809d9872

📥 Commits

Reviewing files that changed from the base of the PR and between fb2e098 and 2b497fa.

📒 Files selected for processing (1)
  • TelegramSearchBot.Test/AppBootstrap/GarnetLuaScriptIntegrationTests.cs

📝 Walkthrough

Walkthrough

The embedded Garnet integration test connection now uses 15-second synchronous and asynchronous timeouts instead of 2 seconds.

Changes

Garnet timeout adjustment

Layer / File(s) Summary
Increase Garnet connection timeouts
TelegramSearchBot.Test/AppBootstrap/GarnetLuaScriptIntegrationTests.cs
ConnectWithRetryAsync changes SyncTimeout and AsyncTimeout from 2,000 to 15,000 milliseconds.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: increasing the Garnet Lua integration test timeout to stabilize failures.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-garnet-lua-timeout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

PR Check Report

Summary

Test Results

Platform Status Details
Ubuntu Passed Tests passed, artifacts uploaded
Windows Passed Tests passed, artifacts uploaded

Code Quality

  • Code formatting check
  • Security vulnerability scan
  • Dependency analysis
  • Code coverage collection

Test Artifacts

  • Test results artifacts count: 2
  • Code coverage uploaded to Codecov

Links


This report is auto-generated by GitHub Actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant