Warm CloudDrive WebDAV directories in order#53
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughChangesThe change adds a shared WebDAV directory-prefix utility and updates playback request resolution and artwork importing to warm every directory from the root through the target parent, with tests covering path generation, call order, deduplication, and expected listings. WebDAV warmup
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant PlaybackHttpRequestResolver
participant webDavDirectoryWarmupChain
participant MediaSource
PlaybackHttpRequestResolver->>webDavDirectoryWarmupChain: Compute directory prefixes
webDavDirectoryWarmupChain-->>PlaybackHttpRequestResolver: Return root-to-parent chain
loop Each directory
PlaybackHttpRequestResolver->>MediaSource: listFiles(directory)
end
PlaybackHttpRequestResolver->>MediaSource: close()
sequenceDiagram
participant MlipLibraryIndexImporter
participant webDavDirectoryWarmupChain
participant MediaSource
MlipLibraryIndexImporter->>webDavDirectoryWarmupChain: Compute artwork directory prefixes
webDavDirectoryWarmupChain-->>MlipLibraryIndexImporter: Return root-to-parent chain
loop Each unwarmed directory
MlipLibraryIndexImporter->>MediaSource: listFiles(directory)
end
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Example order
Validation
Version
Patch release on the existing 2.2 line. Latest stable is v2.2.605; baseAppVersionName remains 2.2.0.
Device status
HK1 ADB is still unauthorized, so no app data was cleared and the APK was not installed on-device.
Summary by CodeRabbit
Bug Fixes
Tests