Repository navigation
tests: make batch.bad_error culture-independent - #65
Merged
Merged
Conversation
Sizing error messages format numbers with the current culture, so on a comma-decimal locale the expectation '-0.1' failed (1145 passed, 1 failed). Build the expected string the same way. Suite now 1146 passed, 0 failed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only fix. The batch.bad_error assertion hard-coded '-0.1', but the library formats the value with the current culture, so on comma-decimal locales it failed (1145 passed, 1 failed). The expectation is now built the same way.
Verified locally (Polish-locale machine): csharp\build.cmd OK; Wenta.Core.Tests.exe 1146 passed, 0 failed.
Note: the library's error messages remain culture-dependent (about 20 sites concatenate doubles); QuickConnect already uses InvariantCulture. Not changed here.
🤖 Generated with Claude Code