feat: Add is_producer_url_unstable to feed schema and expose in API (#1766)#1771
Draft
jcpitre wants to merge 3 commits into
Draft
feat: Add is_producer_url_unstable to feed schema and expose in API (#1766)#1771jcpitre wants to merge 3 commits into
jcpitre wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1766
The rule for updating the DB from the csv file is:
Note: This PR should be merged before this PR from mobility-database-catalogs: Add unstable_producer_url field
#1547
Testing tips:
This PR includes new unit tests.
The whole chain (mobility-database-catalogs -> mobility-feed-api) was tested somewhat, except the notification between the repos that is outside of scope.
The test was:
Export catalogs to CSVworkflow.source.csv. The file will be put in the placed in the mdb-csv (authentication required) bucket.Mobility Catalog Updateworkflow in the current repo.Tested these cases:
TrueanytrueFalseanyfalsenullnulltruetruefalsefalsePlease make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything