Recover the jsonb Jsonb and jsonpath JsonPath collapsed C types#20
Open
estebanzimanyi wants to merge 1 commit into
Open
Recover the jsonb Jsonb and jsonpath JsonPath collapsed C types#20estebanzimanyi wants to merge 1 commit into
estebanzimanyi wants to merge 1 commit into
Conversation
libclang collapses the PG-vendored Jsonb (struct JsonbPair) and JsonPath (struct JsonPathParseItem) pointer types to int during header parsing, the same mechanism already handled for GSERIALIZED/GBOX/Interval/DateADT. Add both to the type-recovery map so the temporal-JSONB (tjsonb) and jsonbset functions carry their real Jsonb*/JsonPath* signatures in the generated IDL that every binding consumes (verified: jsonbset_value_n result recovers to Jsonb**).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libclang collapses the PG-vendored
Jsonb(struct JsonbPair) andJsonPath(struct JsonPathParseItem) pointer types tointduring header parsing — the same mechanism already handled for GSERIALIZED/GBOX/Interval/DateADT in #15. Add both to the type-recovery map so the temporal-JSONB (tjsonb) and jsonbset functions carry their realJsonb*/JsonPath*signatures in the generated IDL that every binding consumes.Verified by regenerating the catalog at the latest pin:
jsonb_in/jsonb_out,tjsonb_start_value,jsonbset_start_valuenow carryJsonb*instead ofint/int*. Without this, catalog-driven bindings see a scalar where JMEOS exposes a Pointer and either drop the function or miscompile.