Repository navigation
GTK: свои картинки в angelos-assets/, сбой одного шага не ломает весь рендер / angelOS's pictures in angelos-assets/, one failed part no longer ends the render - #150
Closed
Alastor1991 wants to merge 2 commits into
Conversation
… ends the render
gtk-live.py wrote its pictures (frames, window buttons, the Mac lights'
glyphs) into ~/.config/gtk-{3,4}.0/assets/. That name is common: adw-gtk3's
old setup links it to the system theme's assets, read-only. The first picture
there failed with PermissionError and the whole render with it, silently:
no angelos-decor.css (no Golden Gate traffic lights), no button layout, no
live theme. GTK 4 apps kept libadwaita's buttons on the right, under angelOS's
CSS, with KDE's layout.
- angelOS's pictures go to a folder of its own, angelos-assets/, next to each
CSS and in its angelOS-a/b themes (8 templates, gtk-live.py, templates.json,
test-update.sh's skip of the GTK 4 versions, the shipped angelos.css). A
folder named assets/ is never written in nor removed. A CSS rendered with
the old assets/ is moved over by version_gtk4's rewrite.
- Each part runs on its own (step()): a failure is said on stderr, the rest
still happens, the button layout always, exit status 1. A half-written
angelOS-a/b theme is not switched to.
Checked on the machine that had the link: the traffic lights on the left,
close,minimize,maximize:, angelOS-a/b, the link left as it was; and with an
unwritable angelos-assets in a scratch HOME (GSETTINGS_BACKEND=memory): the
failure reported, exit 1, the decorations and the theme still written.
check.sh (SKIP_INSTALL_TEST=1): 184 passed, only settings-tree failing, as on
main.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MixaDoDs
added a commit
that referenced
this pull request
Nov 5, 2026
…150) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Баг
gtk-live.pyкладёт свои картинки (рамки, кнопки окон, значки светофора Golden Gate) в~/.config/gtk-{3,4}.0/assets/. Это имя общее: по старой инструкции к adw-gtk3 туда ставят ссылку наassetsсистемной темы, а она доступна только для чтения. Тогда первая же картинка падает сPermissionError, и вместе с ней молча падает весь рендер:angelos-decor.css, то есть нет светофора Golden Gate;angelOS-a/b.В итоге у GTK4-программ остаются кнопки libadwaita справа, поверх них ложится CSS angelOS, и получаются двойные контуры. Раскладка остаётся от прошлого окружения, у меня это была
icon:minimize,maximize,closeот KDE.Исправление
angelos-assets/, рядом с каждым CSS и в темахangelOS-a/b. Изменены 8 шаблонов,gtk-live.py,templates.json, пропуск версий GTK4 вtest-update.shи.config/gtk-4.0/angelos.cssв репозитории. В папкуassets/angelOS больше не пишет и ничего из неё не удаляет. CSS, отрисованный со старым путёмassets/, переносится тем же переписыванием, которымversion_gtk4ставит версию.step(): ошибка печатается в stderr, остальные части выполняются, раскладка кнопок применяется всегда, код выхода 1. Наполовину записанную темуangelOS-a/bскрипт не включает.Проверено
close,minimize,maximize:, темаangelOS-a/b, ссылка осталась как была.HOMEс недоступной для записиangelos-assets(GSETTINGS_BACKEND=memory): ошибка сообщена, код выхода 1, декорации и тема всё равно записаны.scripts/check.sh(SKIP_INSTALL_TEST=1): 184 прошли, падает толькоsettings-tree, как и наmain.EN
gtk-live.pywrote its pictures into~/.config/gtk-{3,4}.0/assets/, a common name: adw-gtk3's old setup links it to the system theme's read-onlyassets. The first picture then failed withPermissionErrorand the whole render with it, silently: noangelos-decor.css(no Golden Gate lights), no button layout, no live theme; GTK 4 apps kept libadwaita's buttons on the right under angelOS's CSS (double rings), with the previous desktop's layout.angelos-assets/, next to each CSS and in itsangelOS-a/bthemes (8 templates,gtk-live.py,templates.json,test-update.sh, the shippedangelos.css).assets/is never written in nor removed; a CSS rendered with the old path moves over byversion_gtk4's rewrite.step()): a failure goes to stderr, the rest still happens, the button layout always, exit status 1; a half-written theme is not switched to.Tested on the machine with the link (lights on the left,
close,minimize,maximize:,angelOS-a/b, the link untouched), with an unwritableangelos-assetsin a scratch HOME (GSETTINGS_BACKEND=memory: reported, exit 1, the rest written), andcheck.sh(184 passed, onlysettings-treefailing, as on main).🤖 Generated with Claude Code