Repository navigation
Golden Gate: зелёная кнопка разворачивает или открывает на весь экран / the green light maximizes or goes fullscreen - #149
Closed
Alastor1991 wants to merge 2 commits into
Closed
Alastor1991 wants to merge 2 commits into
Alastor1991 wants to merge 2 commits into
Conversation
… Windows) angel-niri's title bars (kitty, alacritty, Qt apps that leave their frame to niri) had the green light fixed to fullscreen in Golden Gate: the window went over the menu bar and the Dock onto a workspace of its own, its title bar and lights gone, so nothing but the fullscreen keys brought it back. Settings → Golden Gate → Windows → "The green light" (mac.greenButton): fullscreen (the default, as on a Mac) or maximize (the room between the menu bar and the Dock). In the skin's choices and reset lists; WindowConfig sends it as SetStackingMode's "green". (angel-niri drops the title bar of a maximized window as well; its own fix keeps the bar there, so the green light also restores it.) Checked on a live shell; qml-check: 710 files, 0 errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 1, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MixaDoDs
pushed a commit
that referenced
this pull request
Nov 3, 2026
… one a line Every new Golden Gate setting touched two one-line lists in services/GoldenGate.qml: _watched (what triggers sanitize) and themeKeys (what «Reset the theme» puts back). So any two PRs adding a setting conflicted there (#141, #145, #149, #152, #153 do, pairwise). - _watched is built from the keys of limits and choices: a key with a range or a list of choices is watched by being there (lightFrom and darkFrom, in limits but missing from the old list, are watched now too); - themeKeys, limits and choices hold one key a line, in order, so new settings land on lines of their own. No change in behaviour otherwise. qml-check: 719 files, 0 errors; the Golden Gate system tests pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Зачем
В Golden Gate зелёная кнопка заголовков, которые рисует angel-niri (у kitty, alacritty, Qt-программ, отдающих рамку niri), всегда открывала окно на весь экран (
"green": "fullscreen"вWindowConfig). Окно уходило на отдельный рабочий стол поверх строки меню и Dock, заголовок и светофор пропадали, и вернуть окно можно было только клавишами полноэкранного режима.Что добавлено
Настройки → Golden Gate → Окна → «Зелёная кнопка» (
mac.greenButton):fullscreen(по умолчанию, как сейчас и как на Mac): на весь экран;maximize: развернуть в пространство между строкой меню и Dock.Ключ добавлен в
choicesи в сброс темы.WindowConfigпередаёт его вSetStackingModeкакgreen.Связано с angel-niri
Режим
maximizeпока упирается в angel-niri:Tile::is_titled()требует обычного размера, поэтому у развёрнутого окна заголовок тоже пропадает, и вернуть окно той же кнопкой нечем. Исправление этого вместе с гладким маковским видом заголовка (круглый светофор, сглаженный текст, скруглённые углы) – в MixaDoDs/angel-niri#7. После него и нового релиза angel-niri (data/angel-niri.json)maximizeработает полностью: развёрнутое окно занимает место между строкой меню и Dock со своим заголовком, а зелёная кнопка возвращает его.Проверено
Вживую на шелле.
scripts/qml-check.sh: 710 файлов, 0 ошибок. Правка angel-niri:cargo test --release, 298 тестов прошли; вложенный niri со стопкой,--title-style macи--green maximize: развёрнутое окно 1280×776 под заголовком 24 px на выводе 1280×800, светофор на месте, возврат работает.EN
In Golden Gate the green light of angel-niri's title bars (kitty, alacritty, Qt apps that leave their frame to niri) always went fullscreen: over the menu bar and the Dock, the title bar and lights gone, back only by the fullscreen keys. Settings → Golden Gate → Windows → "The green light" (
mac.greenButton):fullscreen(the default, as now and as on a Mac) ormaximize(the room between the menu bar and the Dock); in the skin's choices and reset lists, sent asSetStackingMode'sgreen.maximizeneeds angel-niri too:Tile::is_titled()asks for the normal sizing mode, so a maximized window loses its bar as well. The fix for that, and the Mac look drawn smooth (round lights, smooth title, round corners), are in MixaDoDs/angel-niri#7; after it and a new angel-niri release (data/angel-niri.json)maximizeworks in full. Tested on a live shell; qml-check 710 files / 0 errors; angel-niri: 298 tests passed, a nested niri with stacking, the Mac look and--green maximize.🤖 Generated with Claude Code