Repository navigation
Golden Gate: Alt+Tab по-маковски и «Системные настройки» вместо Quickshell / Alt+Tab follows the skin, System Settings not Quickshell - #148
Closed
Alastor1991 wants to merge 3 commits into
Conversation
…hell, in the Dock and ⌘Tab - Alt+Tab follows the skin: with Golden Gate it opens the Mac app switcher (AltTabMac, as ⌘Tab does), with the pixel skins their pixel ones as before. Before, Golden Gate had the Mac one only on ⌘Tab, in the Mac key profile; with it off Alt+Tab was always pixel. AltTab's mode (windows | apps) is now apart from the key whose release picks (modKey: meta for ⌘Tab, alt for Alt+Tab), for alt-watch.py and the host's fallback alike. niri's binds are unchanged. - angelOS's Settings window has Quickshell's app id, so its .desktop entry was Quickshell's: the minimized window's corner in the Dock and the Mac switcher showed Quickshell's green gear and name. AppMenu.isShellSettings(w) (what AppMenu.shellSettings and the Dock's System Settings already checked) now decides there too: System Settings, preferences-system. Checked on a live shell by hand (Alt+Tab in Golden Gate); qml-check: 710 files, 0 errors; tests/halo: 25 checks. scripts/test-ui.sh: 504 passed, 13 failed, none in Alt+Tab, the Dock or the Golden Gate pages (the game's demon/exit scenes, OCR, the stream chat, rhythm, the setup wizard, a TypeError in Network.qml); not compared with main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From a review of this PR: «System Settings» and preferences-system were written out in the Dock (twice), Alt+Tab, the menu bar's app name and DockIcons. They are AppMenu.shellSettingsName / shellSettingsIcon now, next to isShellSettings. Alt+Tab builds Settings' entry and an app's with one push. qml-check: 710 files, 0 errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… Golden Gate; «System Settings» as an app Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alt+Tab по скину
В Golden Gate маковский переключатель (
AltTabMac) открывался только по ⌘Tab из профиля маковских клавиш. Если этот профиль выключен, Alt+Tab в Golden Gate всегда показывал пиксельный переключатель, и темы смешивались.Теперь Alt+Tab сам выбирает вид по скину:
Для этого в
AltTabрежим (mode: окна или программы) отделён от клавиши, отпускание которой выбирает (modKey:metaдля ⌘Tab,altдля Alt+Tab). Так работают иalt-watch.py, и запасной путь вAltTabHost. Бинды niri не менялись.«Системные настройки», а не Quickshell
У окна настроек angelOS
app_idQuickshell, поэтому и запись.desktopнаходилась от Quickshell. У свёрнутой миниатюры в Dock и в маковском переключателе показывались зелёная шестерёнка и имя Quickshell. Проверку, которую уже делалиAppMenu.shellSettingsи значок «Системные настройки» в Dock, я вынес вAppMenu.isShellSettings(w). Теперь по ней решают и эти места: имя «Системные настройки», значокpreferences-system.Проверено
scripts/qml-check.sh: 710 файлов, 0 ошибок.tests/halo/run.sh: 25 проверок.scripts/test-ui.sh: 504 прошли, 13 упали. Среди упавших нет ни Alt+Tab, ни Dock, ни страниц Golden Gate: это сцены демона и выхода в игре, OCR, чат стрима, ритм-режим, мастер первого запуска иTypeErrorвNetwork.qml. Сmainя это не сравнивал.EN
modeis now apart from the key whose release picks (modKey:metafor ⌘Tab,altfor Alt+Tab), foralt-watch.pyand the host's fallback alike. niri's binds are unchanged.AppMenu.isShellSettings(w)(whatAppMenu.shellSettingsand the Dock's System Settings already checked) decides there too.Tested by hand on a live shell; qml-check 710 files / 0 errors; tests/halo 25 checks; test-ui 504 passed, 13 failed, none in Alt+Tab, the Dock or the Golden Gate pages (not compared with main).
🤖 Generated with Claude Code