Repository navigation
Golden Gate: меню приложения по правому клику в Spotlight (Открыть, действия, Оставить в Dock) / Spotlight: an app's menu on a right click - #144
Closed
Alastor1991 wants to merge 3 commits into
Conversation
…ons, Keep in Dock) Apps could be kept in the Dock only from the Dock itself (a running app's menu) or from Settings → Dock. A right click on an app in Spotlight, in the Apps grid or among the results, now opens its menu, as the Dock's: Open, the app's own .desktop actions, Keep in Dock (a check, MacDockModel.setKept, the same ids). The menu is a MacMenuView drawn inside Spotlight, so it is never under its window. Over the results panel's glass a glass menu couldn't be read, so it is solid (GoldenGate.contentBg; MacMenuView takes a `fill` now, glassFill by default) and the panel dims a little under it; StartOverlay blurs under it too. Esc, a click beside it, typing or another mode close it. Checked on a live shell (light theme, the grid and the results); qml-check: 710 files, 0 errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From a review of this PR: the .desktop actions and «Keep in Dock» were copied from the Dock's menu (MacDockModel.menuFor). Both menus now take them from MacDockModel (actionItems, keepItem). The two rows' click lambdas are one function, clickRow. qml-check: 710 files, 0 errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rder note) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Зачем
Оставить приложение в Dock можно было только из самого Dock (меню запущенной программы) или из Настроек → Dock. Из общего списка приложений закрепить его было нельзя.
Что добавлено
Правый клик по приложению в Spotlight, в сетке «Приложения» и в результатах поиска, открывает его меню, как у Dock:
.desktop(новое окно, приватное окно и т. п.);MacDockModel.setKeptи те же id, что в меню Dock.Как сделано
MacMenuView, нарисованный внутри Spotlight, поэтому он никогда не оказывается под его окном.GoldenGate.contentBg), а панель под ним слегка темнеет. УMacMenuViewпоявилось свойствоfill, по умолчаниюglassFill, так что остальные меню не изменились.StartOverlayразмывает фон и под этим меню.Проверено
На живом шелле (niri 26.04, angel-niri
ce52b4a8, светлая тема): сетка и результаты, закрепление и снятие.scripts/qml-check.sh: 710 файлов, 0 ошибок.EN
Apps could be kept in the Dock only from the Dock itself or from Settings → Dock. A right click on an app in Spotlight (the Apps grid or the results) now opens its menu, as the Dock's: Open, the app's own
.desktopactions, Keep in Dock (a check;MacDockModel.setKept, the same ids as the Dock menu).The menu is a
MacMenuViewdrawn inside Spotlight, so it is never under its window. Over the results panel's glass a glass menu couldn't be read: it is solid (GoldenGate.contentBg;MacMenuViewtakes afillnow,glassFillby default) and the panel dims a little under it; StartOverlay blurs under it too. Esc, a click beside it, typing or another mode close it. Tested on a live shell (light theme); qml-check 710 files / 0 errors.🤖 Generated with Claude Code