feat!: give et short flags their OpenSSH meanings - #867
Merged
Merged
Conversation
Let editors such as VS Code Remote-SSH use et (or et1) as their ssh binary. Short letters on the et client now match ssh(1); long options keep ET behavior. - -c cipher, -t pty, -p sshd port, -l login user, -x no-op, -f background, -N no remote command, -v repeatable, -e accepted. - New -L/-R (incl. 3-field port:host:hostport), -i, -J. - Pre-pass expands short clusters and stops at the host so remote command flags stay in the command. - -T no longer prints SSH login output on stdout, and the bootstrap ssh gets stdin=/dev/null so it cannot eat the caller's stdin. BREAKING CHANGE: et -c/-t/-p/-l/-x/-f/-N/-v/-e changed meaning. Use --command, --tunnel, --port, --logdir, --kill-other-sessions, --forward-ssh-agent, --no-terminal, --verbose=N, --noexit. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #867 +/- ##
==========================================
+ Coverage 78.55% 78.75% +0.19%
==========================================
Files 143 143
Lines 17624 18065 +441
Branches 11233 11537 +304
==========================================
+ Hits 13845 14227 +382
- Misses 2254 2299 +45
- Partials 1525 1539 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lets VS Code / Cursor Remote-SSH use
et(oret1) asremote.SSH.path: short letters on theetclient now mean what they mean inssh(1). Long options keep ET behavior.etserver,etterminal, andhtmare unchanged.Breaking: these short letters changed meaning on the client. Use the long form for the old behavior.
-c--command(or positional command)-t--tunnel(or-L)-p--port/host:port(etserver)-l--logdir-x--kill-other-sessions-f--forward-ssh-agent-Nno_shell)--no-terminal-v--verbose=N-e--noexitAlso:
-L/-R(including OpenSSH 3-fieldport:host:hostport, bound to localhost),-i,-J.-vvv,-NT,-p22,-Cl alice) and stops at the host, so flags in the remote command stay there. Unhandled ssh letters no longer end a cluster; unhandled value letters drop their value.-preaches the bootstrap ssh only when given, so ssh config and--ssh-option Port=keep working.et1: with-T, SSH login output no longer goes to stdout (the remote command's channel); the bootstrapsshnow gets stdin from/dev/null, so it cannot swallow the install script VS Code writes before the session is up.scripts/ssh-et, system tests, iTerm2 e2e, README,docs/protocol.md, bash/zsh completions.The server side needed for VS Code (
-Traw channel #854, runtime-D/-W#849) is already on master; no release contains it yet.Test plan
ctest --parallel(408/408) inbuild/ClientArgParsingTest,TunnelUtilsTest,SubprocessUtilsTest,SshSetupHandlerTest--style=Google) clean on changed C++ filesremote.SSH.path=et1, connecting to a Linux host running master'setserver; VS Code server installed and extension host started