Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #828 +/- ##
========================================
Coverage 79.88% 79.88%
========================================
Files 152 153 +1
Lines 22144 22354 +210
Branches 14338 14472 +134
========================================
+ Hits 17690 17858 +168
- Misses 2641 2661 +20
- Partials 1813 1835 +22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MisterTea
marked this pull request as draft
September 20, 2026 16:37
Keep the stable SSH agent proxy path while taking master's TerminalClient changes. Co-authored-by: Cursor <cursoragent@cursor.com>
Returning clients keep the server-side tunnel destination, so the local symlink has to follow SSH_AUTH_SOCK when the connection comes back. Co-authored-by: Cursor <cursoragent@cursor.com>
MisterTea
marked this pull request as ready for review
September 27, 2026 20:41
Portability CI failed because refreshAgentProxyPath removed agent.sock before recreating it, so reconnect tests could race on read_symlink. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SSH_AUTH_SOCKafter an in-process reconnect and on saved-session reattach.SSH_AUTH_SOCKdoes not change when the local agent socket does.Closes #506.
Test plan
refreshAgentProxyPath creates and retargets agent proxy socketTerminalClient reattach retargets SSH agent proxyTerminalClient in-process reconnect retargets SSH agent proxybash format.shctest --parallel --output-on-failurein the issue-506 worktree