Conversation
… needs I/O changes)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #823 +/- ##
=======================================
Coverage 79.88% 79.89%
=======================================
Files 152 152
Lines 22144 22179 +35
Branches 14338 14365 +27
=======================================
+ Hits 17690 17720 +30
- Misses 2641 2647 +6
+ Partials 1813 1812 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MisterTea
changed the title
MisterTea
changed the title
MisterTea
marked this pull request as draft
September 20, 2026 16:37
…dget. Preserve master's SOCKS/stdio forwarding path while retaining the 64 KiB per-update read limit and 16 KiB chunks that prevent busy TCP tunnels from starving the terminal event loop (#298). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limits each forwarding handler to 64 KiB per event-loop pass, uses 16 KiB chunks, and adds regressions for the byte budget on both the source and destination forwarders. This prevents one busy tunnel from starving other tunnels or terminal traffic.
Merged current master so the budget sits on the SOCKS and stdio source path. The Catch2 tag is
issue298because a#tag makes test discovery fail.Test plan
ForwardDestinationHandler yields after a bounded data batch: five queued 16 KiB reads, handler stops after four (64 KiB).ForwardSourceHandler update yields after a bounded data batch: same budget on the source handler.Closes #298.