Skip to content

Fix unbounded RefreshOpenState recursion when player controls are already disabled #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Drheisen1 wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −1
Open

Fix unbounded RefreshOpenState recursion when player controls are already disabled #110

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
746395b
re-entrancy guard
Drheisen1 Jun 18, 2026
882ffbe
Update src/MenuVisibilityManager.cpp
Drheisen1 Jun 18, 2026
dc99220
Merge branch 'main' into main
Drheisen1 Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/MenuVisibilityManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,15 @@ namespace QuickLoot
{
PROFILE_SCOPE;

// Prevent reentry to avoid infinite recursion
static bool refreshing = false;
if (refreshing) {
return;
}
refreshing = true;
struct RefreshGuard {
~RefreshGuard() { refreshing = false; }
} refreshGuard;
// Don't refresh while the console is open to work around the missing cursor bug
// (any menu events while the console is open cause the cursor to disappear)
if (RE::UI::GetSingleton()->IsMenuOpen(RE::Console::MENU_NAME)) {
Expand Down Expand Up @@ -424,4 +433,4 @@ namespace QuickLoot
}

#pragma warning(pop)
}
}

@AtomCrafty AtomCrafty Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the newline at the end