refactor(codegen)!: drop redundant Flows and Compensations API sections - #85
Merged
Conversation
Remove the generated `Flows` and `Compensations` sections plus the now-unused `BpmnFlow` and the dead `BpmnRelations` runtime types. Process shape (every sequence flow with its condition/default, every element) is served by the Process JSON v2 export; compensation element ids already live in `Elements`. Nothing consumed `Flows` (not the ProcessPath DSL, testing or web modules), and `Compensations` only re-listed ids from `Elements`. Compensation stays a first-class domain concept — extraction and JSON output are unchanged; only the redundant code-generation sections go. BREAKING CHANGE: generated Process APIs no longer contain the `Flows` or `Compensations` objects, and the `BpmnFlow` and `BpmnRelations` runtime types are removed. Read sequence flows from the JSON export; use `Elements` for compensation element ids. Co-authored-by: Claude <noreply@anthropic.com>
emaarco
force-pushed
the
emaarco/next-outgoing-requirement
branch
from
August 14, 2026 12:15
83527c7 to
9c0c73f
Compare
emaarco
enabled auto-merge (squash)
August 14, 2026 12:16
Contributor
|
Test Coverage
|
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes generated-API content that duplicates other, better sources — a net removal of ~630 lines.
Flowssection + theBpmnFlowruntime type — the process shape (every sequence flow withcondition/isDefault, every element) is served richer by the Process JSON v2 export. Nothing consumed the generatedFlowsobject: not theProcessPathnavigation DSL, nor thetesting/webmodules.Compensationssection — only re-listedElementIdconstants already present inElements. It resembles theMessages/Signalspattern but isn't equivalent: those surface a distinct semantic key (the message/signal name), whereas compensation's reference is an element id, so the section could only duplicateElements.BpmnRelationsruntime type (emitted by no generator since the reshapedRelationslanded).Compensation stays a first-class domain concept —
CompensationDefinition, extraction across all engines, and the JSON export are unchanged. Only the redundant code-generation sections go.Breaking
Generated Process APIs no longer contain the
FlowsorCompensationsobjects; theBpmnFlowandBpmnRelationsruntime types are removed.Elementsfor compensation element ids.Verification
./gradlew buildgreen (all modules, ktlint + detekt + konsist architecture tests + coverage).