Skip to content

Minor Clean up #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tcyrus wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Minor Clean up #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
404659f
Update anime_planet.py
tcyrus Dec 15, 2019
35e8480
Update kitsu.py
tcyrus Dec 15, 2019
3ab564c
Update anime_planet.py
tcyrus Dec 15, 2019
e993375
Update mu.py
tcyrus Dec 15, 2019
de2a3a2
Update anime_planet.py
tcyrus Dec 15, 2019
7c77a92
Update nu.py
tcyrus Dec 15, 2019
50ad4c6
Update lndb.py
tcyrus Dec 15, 2019
f945bdc
Update ani_list.py
tcyrus Dec 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions minoshiro/web_api/ani_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def match_max(thing: dict, matcher: SequenceMatcher) -> float:
matcher.set_seq1(name.lower())
ratio = matcher.ratio()
if 'one shot' in thing['type'].lower():
ratio = ratio - .05
ratio -= .05
if ratio > max_ratio:
max_ratio = ratio
return max_ratio
Expand Down Expand Up @@ -193,10 +193,7 @@ async def get_page_by_popularity(session_manager, medium: Medium,


def __get_query_string(medium, query, search=False) -> str:
if medium == Medium.ANIME:
med_str = 'ANIME'
else:
med_str = 'MANGA'
med_str = 'ANIME' if medium == Medium.ANIME else 'MANGA'
if search:
full_str = f'''Page (page: 1, perPage: 40) {{
media (search: "{query}" type: {med_str})'''
Expand Down
4 changes: 2 additions & 2 deletions minoshiro/web_api/anime_planet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def get_anime_url_by_id(anime_id) -> str:

:return: the anime url.
"""
return 'http://www.anime-planet.com/anime/' + str(anime_id)
return f'http://www.anime-planet.com/anime/{anime_id!s}'


def get_manga_url_by_id(manga_id) -> str:
Expand All @@ -145,7 +145,7 @@ def get_manga_url_by_id(manga_id) -> str:

:return: the manga url.
"""
return 'http://www.anime-planet.com/manga/' + str(manga_id)
return f'http://www.anime-planet.com/manga/{manga_id!s}'


def __get_closest(query: str, anime_list: List[dict], names) -> dict:
Expand Down
2 changes: 1 addition & 1 deletion minoshiro/web_api/kitsu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def match_max(thing: dict, matcher: SequenceMatcher) -> float:
matcher.set_seq1(name.lower())
ratio = matcher.ratio()
if 'one shot' in thing['type'].lower():
ratio = ratio - .05
ratio -= .05
if ratio > max_ratio:
max_ratio = ratio
return max_ratio
Expand Down
2 changes: 1 addition & 1 deletion minoshiro/web_api/lndb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def get_light_novel_by_id(ln_id) -> str:

:return: the ln url
"""
return 'http://lndb.info/light_novel/' + str(ln_id)
return f'http://lndb.info/light_novel/{ln_id!s}'


def __get_closest(query: str, ln_list: List[dict], names) -> dict:
Expand Down
2 changes: 1 addition & 1 deletion minoshiro/web_api/mu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def get_manga_url_by_id(manga_id) -> str:

:return: the manga url.
"""
return 'https://www.mangaupdates.com/series.html?id=' + str(manga_id)
return f'https://www.mangaupdates.com/series.html?id={manga_id!s}'


def __get_closest(query: str, manga_list: List[dict], names) -> dict:
Expand Down
2 changes: 1 addition & 1 deletion minoshiro/web_api/nu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def get_light_novel_by_id(ln_id: str) -> str:

:return: the ln url.
"""
return 'http://novelupdates.com/series/' + str(ln_id)
return f'http://novelupdates.com/series/{ln_id!s}'


def __get_closest(query: str, ln_list: List[dict], names) -> dict:
Expand Down