Skip to content

🎨 Palette: Replace icon buttons with IconButton - #964

Open
Mihir-Rabari wants to merge 1 commit into
mainfrom
palette/fix-icon-buttons-14189244470878762244
Open

Mihir-Rabari wants to merge 1 commit into
mainfrom
palette/fix-icon-buttons-14189244470878762244

Conversation

@Mihir-Rabari

Copy link
Copy Markdown
Owner

💡 What: Replaced native <button> elements that only contained icons with the existing IconButton component in the app details and new app pages.\n🎯 Why: Native buttons used for icons often lack aria-label or enforce it weakly, leading to missing screen reader labels for icon-only actions (like "Copy API Key"). IconButton strictly requires an aria-label attribute and handles title fallbacks and consistent focus styles out-of-the-box.\n📸 Before/After: Code change only, visually identical but using standard components.\n♿ Accessibility: Ensures all icon-only buttons have enforced aria-label attributes and consistent focus ring states for keyboard users.


PR created automatically by Jules for task 14189244470878762244 started by @Mihir-Rabari

Co-authored-by: Mihir-Rabari <169349389+Mihir-Rabari@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant