Repository navigation
π‘οΈ Sentinel: [CRITICAL] Remove hardcoded database credentials - #962
Mihir-Rabari wants to merge 1 commit into
Conversation
Removed hardcoded database credentials (`gateway_user:gateway_pass`) that were used as fallbacks for `DATABASE_URL` in `apps/api/src/routes/v1/apps.ts` and `apps/api/src/routes/v1/developers.ts`. Injected `DATABASE_URL` into the CI workflow to maintain test integrity. Co-authored-by: Mihir-Rabari <169349389+Mihir-Rabari@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Hardcoded database credentials (
gateway_user:gateway_pass) were used as fallbacks forDATABASE_URLinapps/api/src/routes/v1/apps.tsandapps/api/src/routes/v1/developers.ts.π― Impact: An attacker gaining access to the codebase could extract these credentials and attempt to access the database, leading to potential data breaches.
π§ Fix: Removed the hardcoded credentials and injected
DATABASE_URLinto the CI workflow.β Verification: Ran
pnpm build,pnpm lint, andpnpm test. Verified thatDATABASE_URLis correctly injected in CI.PR created automatically by Jules for task 11185933855348422032 started by @Mihir-Rabari