Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix hardcoded database credentials - #955

Open
Mihir-Rabari wants to merge 1 commit into
mainfrom
sentinel/fix-hardcoded-db-creds-586211126820453567
Open

Mihir-Rabari wants to merge 1 commit into
mainfrom
sentinel/fix-hardcoded-db-creds-586211126820453567

Conversation

@Mihir-Rabari

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Hardcoded PostgreSQL database URLs with username and password were present as fallbacks in apps/api/src/routes/v1/apps.ts and apps/api/src/routes/v1/developers.ts.
🎯 Impact: Exposing hardcoded database credentials in the codebase can lead to unauthorized database access if the code is exposed or if these staging/local credentials are inadvertently reused in higher environments.
πŸ”§ Fix: Removed the hardcoded fallback credentials and instead throw an explicit error if the DATABASE_URL environment variable is missing during initialization. Also updated .github/workflows/ci.yml to set test database urls in env.
βœ… Verification: Ensure the application starts correctly when DATABASE_URL is set, and immediately crashes with a clear error when it is missing, preventing insecure connections. Tests passing.


PR created automatically by Jules for task 586211126820453567 started by @Mihir-Rabari

Co-authored-by: Mihir-Rabari <169349389+Mihir-Rabari@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant