Skip to content

🎨 Palette: Remove redundant sr-only text from dialog close buttons - #952

Open
Mihir-Rabari wants to merge 1 commit into
mainfrom
palette-remove-redundant-sr-only-7332382892905107331
Open

Mihir-Rabari wants to merge 1 commit into
mainfrom
palette-remove-redundant-sr-only-7332382892905107331

Conversation

@Mihir-Rabari

Copy link
Copy Markdown
Owner

💡 What: Removed the visually hidden <span className="sr-only">Close dialog</span> element from the DialogPrimitive.Close button inside apps/web/src/components/ui/dialog.tsx, and migrated the title="Close dialog" attribute to explicitly include aria-label="Close dialog".
🎯 Why: Adding both an accessible label attribute (via title or aria-label) and an inner .sr-only text node to the same interactive element is a known accessibility anti-pattern. Screen readers may misinterpret this structure, leading to duplicated announcements (e.g., "Close dialog Close dialog button") or a confused accessibility tree.
📸 Before/After: Visual presentation is completely unchanged. The accessibility tree is now cleaner for assistive technologies.
♿ Accessibility: Ensures a single, reliable accessible name is computed for the close button, preventing screen reader repetition and improving overall navigation clarity.


PR created automatically by Jules for task 7332382892905107331 started by @Mihir-Rabari

Co-authored-by: Mihir-Rabari <169349389+Mihir-Rabari@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant