Repository navigation
Require PR security scans and wallet recovery regressions - #3
Open
dotmantissa wants to merge 2 commits into
Open
dotmantissa wants to merge 2 commits into
dotmantissa wants to merge 2 commits into
Conversation
dotmantissa
enabled auto-merge
November 3, 2026 17:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR validation previously omitted connected wallet journeys, static analysis and development dependency advisories. Require strict pinned Semgrep scanning, workflow privilege/secret policy regressions, complete JS auditing and weekly validation, while keeping production gated behind CI on trusted main events. Update sharp to 0.35.5 to resolve the newly detected high-severity advisories; expand CODEOWNERS and npm/pip Dependabot maintenance.
Add seven production-build Chromium flows using the shipped Freighter adapter and packed SDK with ephemeral Node-side signers and simulated RPC/API responses: stale quote/review preserves user bounds, tampered review rejection, expiry, account change during approval, changed signed bytes, response-loss identical retry with one signature, and unresolved receipt reload. Test types are required. Security rules retain upstream license, immutable provenance and checked hashes; injected SQL/eval and workflow mutations prove rejection.
Validation: full audit reports no known vulnerabilities; build/application/test types, four unit tests, copy/embed checks, all 13 browser cases, ten release-policy tests, strict SAST, Gitleaks, Actionlint and immutable sibling/SDK/WASM compatibility pass locally. CI_SECURITY.md documents scope and maintenance. Existing production settings and SDK provenance are preserved. Protected main still requires an independent code-owner approval.