Skip to content

Remove stray replace.patch from the repo#174

Merged
laffer1 merged 1 commit into
mainfrom
remove-stray-replace-patch
Jul 3, 2026
Merged

Remove stray replace.patch from the repo#174
laffer1 merged 1 commit into
mainfrom
remove-stray-replace-patch

Conversation

@laffer1

@laffer1 laffer1 commented Jul 3, 2026

Copy link
Copy Markdown
Member

replace.patch was a leftover diff artifact accidentally committed (in #162). It is not referenced by the build or tests, and its content is stale — it adds <ctype.h> to tests/mport_util_test.c, which uses no ctype functions and whose current include block no longer matches the patch context.

Removing it; nothing depends on it.

🤖 Generated with Claude Code

Summary by Sourcery

Chores:

  • Delete a stray patch artifact that is no longer used by the build or tests.

replace.patch was a leftover diff artifact accidentally committed. It is
not referenced by the build or tests, and its content is stale (it adds
<ctype.h> to tests/mport_util_test.c, which uses no ctype functions and
whose current includes no longer match the patch context).

AI-Assisted-By: Claude Opus 4.8 (1M context)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This pull request removes an unused, stale patch file (replace.patch) that was accidentally committed and is not referenced by the build or tests.

File-Level Changes

Change Details Files
Delete an unreferenced, stale patch artifact from the repository.
  • Remove replace.patch, which was a leftover diff artifact from a previous change.
  • Ensure no build, test, or tooling references depend on replace.patch.
replace.patch

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

Claude finished @laffer1's task in 33s —— View job


Reviewing PR #174

  • Gather context (diff, PR description)
  • Verify replace.patch isn't referenced anywhere (build, tests, CI, docs)
  • Verify the "stale" claim about <ctype.h> in tests/mport_util_test.c
  • Post review feedback

Review

Verified both claims in the PR description:

  • Unreferenced: grep -rn "replace.patch" across the tree (excluding .git/) returns no hits — not mentioned in any Makefile, CI workflow, or doc.
  • Stale: the patch adds #include <ctype.h> to tests/mport_util_test.c, but the current file has no ctype.h-family calls (isalpha, isdigit, toupper, etc. — confirmed via grep), and its current include block (sys/cdefs.h, sys/param.h, sys/stat.h, atf-c.h, stdbool.h, stdio.h, stdlib.h, string.h, unistd.h) doesn't match the patch's context lines anyway, so it wouldn't apply cleanly even if it were still relevant.

This is a clean, correctly scoped deletion of a dead artifact (0 additions / 9 deletions, single file). No build, test, or CI references depend on it. No memory-safety, SQL, or path-traversal surface here since it's just a leftover text file — nothing to flag.

LGTM.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@laffer1 laffer1 merged commit 497a7e0 into main Jul 3, 2026
5 of 6 checks passed
@laffer1 laffer1 deleted the remove-stray-replace-patch branch July 3, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant