Skip to content

feat: add request duration histogram for golden-signal latency #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tiago0507 merged 1 commit into from
Aug 24, 2026
Merged

feat: add request duration histogram for golden-signal latency #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ function createApp (options = {}) {
labelNames: ['method', 'status'],
registers: [register]
});
const requestDuration = new prometheus.Histogram({
name: 'todo_api_request_duration_seconds',
help: 'Duration of requests handled by the Todo API',
labelNames: ['method'],
registers: [register]
});
prometheus.collectDefaultMetrics({ register, prefix: 'todos_api_' });

app.get('/metrics', async (req, res) => {
Expand All @@ -69,7 +75,11 @@ function createApp (options = {}) {
});

app.use((req, res, next) => {
res.on('finish', () => requestCount.labels(req.method, String(res.statusCode)).inc());
const stopTimer = requestDuration.startTimer({ method: req.method });
res.on('finish', () => {
requestCount.labels(req.method, String(res.statusCode)).inc();
stopTimer();
});
next();
});
app.use(expressjwt({
Expand Down
Loading