Repository navigation
SimplrSSH - Accessibility AAA - 2026-10-16 - #23
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MhbixBmwdwHL69hVrAaDPb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings (WCAG 2.2 AAA 1.4.6 enhanced contrast; 1.4.11 focus indicator)
Source:
main/include/ui_view.hpptheme tokens (all colors are centralized there). Measured contrast ratios:DIMtext (hints, details, placeholder, chat info lines): 6.15:1 on BG, 5.62 on SURFACE, 4.95 on DIVIDER (<7). Affects every screen on both boards.DANGERtext (battery low): 5.65 / 5.16 / 4.54 (<7).OK/WARNon SURFACE: 6.81 / 6.85 (<7).ACCENTfill (selected row, user chat bubbles, pressed side-panel button): 3.75:1; selected-row dim text (SELECTED_DIM): 2.76:1; mark text drawn in ACCENT on white: ~3.7. Severity High: the selected row is the focus indicator users rely on.Plan / changes
theme::ACCENT_BG(0x0D47A1) for fills behind white text;ACCENT(bright, 5.05:1 vs BG) stays for borders/focus outline only. Used inui_view.cpp(selected row, marks),chat_app.cpp(user bubble),ssh_terminal.cpp(pressed button).DIM0xB1BAC4,DANGER0xFFA198,OK0x56D364,WARN0xE3B341;SELECTED_DIM0xE6EDF3.Contrastintest/guards/test_firmware_rules.pyenforces >=7:1 for all text/fill pairs and 3:1 for the focus outline; rule noted in AI_RULES.md.Gap analysis (final)
Deferred (need product decision or hardware)
term_view.cpp: green on black, ANSI colors such as 0x666666/0xCD3131/0x2472C8 on black fall below 7:1) - those are server-chosen colors; a 7:1 clamp changes terminal fidelity.Verification
cd test/guards && python3 -m unittest test_supply_chain test_firmware_rules test_rules_file test_ci_scripts- passes (incl. new Contrast test).SKIP_SAST=1 scripts/check.sh- guards pass; host cmake step fails in this sandbox (mbedcrypto dev library missing), so host unit tests and SAST were not run locally; CI will run them.ruff check test: 11 pre-existing findings, same count before and after this change.🤖 Generated with Claude Code
https://claude.ai/code/session_01MhbixBmwdwHL69hVrAaDPb
Generated by Claude Code