ascal: fix stale right-edge pixel on the last active column - #36
Open
Takiiiiiiii wants to merge 1 commit into
Open
ascal: fix stale right-edge pixel on the last active column#36Takiiiiiiii wants to merge 1 commit into
Takiiiiiiii wants to merge 1 commit into
Conversation
At the last active column the output line-buffer read can return stale data when horizontal blanking is tight (the fill lags the read by one pixel), producing a single corrupted column at the right edge on a full-width 1:1 framebuffer. Repeat the previous (valid) pixel at the last active column instead of emitting the stale one.
Member
|
This fix is incorrect. It doesn't fix the original problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the last active column, the output line-buffer read will return data from the center of the display when horizontal blanking is tight. This produces a single corrupted column at the right edge on a full-width 1:1 1080p/60 framebuffer. This PR repeats the previous (valid) pixel at the last active column instead of emitting a random one.