Reduction of memory footprint - #1203
Open
Slamy wants to merge 1 commit into
Open
Conversation
Member
|
The question I would ask here is what actual problem is this solving? Are we getting close to running out of RAM? Changes for the sake of changes without solving a real issue are usually undesirable and can potentially introduce unforseen bugs. |
Contributor
Author
|
I do have to admit that this change actually fixes no real life issues right now since we probably have enough RAM for now. It was mostly a suggestion based on a sudden notice when I've discovered that this kind of buffer existed multiple times in the MiSTer application. I don't even know how many of these buffers even exist that have a single use purpose and then never again. Edit: It was meant to show that there are nicer solutions. |
- Removes 100kB of memory per CD supporting core for CUE file loading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change might be controversial. It already got negative feedback on the MiSTer Discord from other devs since it uses C++14 methods of memory allocation.
I could think of an alternative, like a global buffer for this task. Many of the CD cores don't really share code, but I believe this is a small change to at least reduce memory usage in case it might be a problem in the future.