Anbar Hussain - #4
Open
anbar-h wants to merge 3 commits into
Open
Conversation
functionality for booking a room has been implemented with validation
check cache first, otherwise call api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anbar Hussain
Task Report
The commit log accurately reflects the order of tasks I worked on, but the timing is not fully precise due to breaks between tasks. Initially, I spent approximately an hour setting up the project, ensuring it ran properly, and creating a
launch.jsonfile in Visual Studio Code to facilitate debugging. After that, I proceeded with completing the tasks in the following order: RE#001, RE#002, and RE#003. I spent the full 180 mins on the task (excludes project setup time).If I had more time, I would have focused on the following improvements:
Testing: Implemented tests to ensure code reliability and coverage.
UI Enhancements: Improved the user interface validation for better user experience.
Performance Improvements for RE#003: Added features such as paging, sorting, and filtering to handle larger datasets efficiently. I would also have focused on optimizing the indexing to improve data retrieval speed.
Overall, I feel the tasks were completed successfully, and while some optimizations were skipped due to time constraints, the implementation is functional and aligns with the requirements. I would have done more refactoring if I had time.
Notes
React Experience: While I don’t have professional industry experience with React, I tried my best to implement the tasks with the limited knowledge I have. With more time, I would have refined my approach and further enhanced the implementation.