fix: 1.21.11 maintenance (build, deps, Criticals NPE) - #134
Open
Merennor wants to merge 11 commits into
Open
Conversation
Also fixes "Cannot remap access widener from namespace 'official'. Expected: 'intermediary'"
instead of using a local lib in the repo
Both integrations were removed a while ago; this cleans up remaining mentions (comments, docs, dead config checks) that were never deleted.
not referenced anywhere in build scripts.
Newer loom version broke Gradle sync / build compatibility; pinning to last known-working release.
Methods were never called; accessor was causing a StackOverflowError.
Modules.get(Class) is annotated @nullable and can return null, causing an NPE in allowCrit() when chained directly into isActive(). Replace with Modules.get().isActive(Criticals.class), which performs the null check internally. Fixes MeteorClientPlus#131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maintenance and backport of fixes/changes for the 1.21.11 branch.
Changes
Build & dependencies
Cannot remap access widener from namespace 'official'. Expected: 'intermediary'Cleanup (backport from 26.1+ branches)
Bug fix
allowCrit()—Modules.get(Criticals.class)is@Nullable-> switch toModules.get().isActive(Criticals.class).Fixes [Crash] #131