feat(portfolio): add monthly cash withdrawal & fix table column alignment - #3
Merged
Conversation
Introduce inflation-protected safe withdrawal calculations and surface them across the app. Adds calculateSafeWithdrawal() to inflation-adjust, integrates per-month safeWithdrawal/realSafeWithdrawal into calculateProjection (rows + summary totals), updates types, CSV export, table and summary card UI, tests, and i18n strings. Safe withdrawal is zero when returns <= inflation; amounts are rounded to 2 decimals for consistency.
- Remove duplicate usdValueCol header in ProjectionTable - Reorder headers to strictly match tbody column sequence
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces monthly cash withdrawal simulation to the portfolio projection engine and fixes a column alignment bug in the detail table.
Changes
✨ Feature: Monthly Cash Withdrawal (
monthlyWithdrawal)Allows users to define a regular monthly cash withdrawal from the portfolio. The withdrawal is deducted from the portfolio balance after each month's compound growth, ensuring accurate long-term simulations.
ProjectionParams— newmonthlyWithdrawal?: numberfield (default:0)ProjectionRow— newwithdrawal: numberfield per rowProjectionSummary— newtotalWithdrawalsandtotalRealWithdrawalscumulative metricscalculateProjection) — withdrawal deducted after each compound step:actualWithdrawal = min(balance, plannedWithdrawal)Monthly Withdrawalcolumn and totals added to export🐛 Fix: Projection Table Column Alignment
Removed duplicate
usdValueColheader that caused an 11-header / 10-cell mismatchCorrected header order to strictly align with body column sequence:
Period | DCA | Invested | Nominal Value | Nominal P&L | Real Value | Real P&L | Safe Withdrawal | Ref. FX Value | FX RateVerification
npm run testnpm run buildnpm run lint