fix(compose): repair docker-compose and add redis service - #16
Merged
Conversation
PR #15 squash left a malformed docker-compose.yml: a duplicated frontend block tail, a redis-data volume but no redis service, and the obsolete version key. Repair the structure and add a real redis:7-alpine service so SECURESCAN_REDIS_URL is wired end to end. - Drop obsolete version field - Add redis service with appendonly persistence and ping healthcheck - Backend now depends_on redis and accepts SECURESCAN_REDIS_URL and SECURESCAN_REDIS_KEY_PREFIX from the environment - Compose now validates with docker compose config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The squash-merge of #15 left
docker-compose.ymlin a broken state:ports/environment/depends_onre-stating the frontend service aftervolumes:had already opened).redis-data:volume declared but noredisservice consuming it.version: "3.9"key, which Compose v2 warns about.docker compose configwas loadable but the file was clearly half-finished, andSECURESCAN_REDIS_URLhad no in-cluster target.Fix
versionkey.redis:7-alpineservice withappendonly yesand aredis-cli pinghealthcheck.depends_on: [redis]and readsSECURESCAN_REDIS_URL+SECURESCAN_REDIS_KEY_PREFIXfrom the environment, so a defaultdocker compose upnow wires the pubsub backplane end to end without extra configuration.Verification
Cross-instance fanout was already proven against a real Redis 7 in #15's tests; this PR just makes the default deployment path actually start one.