Repository navigation
fix(story): include CRI categories in sound products - #88
Merged
Merged
Conversation
Read each cue's category names from the ACB when assembling story.sound. Record nonempty lists in cues.json and version the stage so cached sound products are recomputed. Audio files and decoded stream records retain their existing contracts.
Use the test encoder for the shared audio atom lookup as well as the sound assembler so synthetic category tests run without an installed ffmpeg executable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
story.soundnow includes each cue's nonempty CRI category list incues.json, read from the cue's ACB sequence. Thecategoriesfield contains the ordered names fromacb.cue_categories, allowing playback volume to follow the cue sheet's categories. The stage version is 2 so existing sound products are recomputed.Validation: synthetic ACB tests cover AAC and FLAC output, cues without categories, first-stream selection, encoder delay, stream records and cache keys. The local test suite passed with 1671 tests and 6 skips; lint, formatting and import contracts passed.