Repository navigation
fix(story): name the CRI categories of each cue in cues.json - #87
Merged
Merged
Conversation
The volume of a CRI category reaches a cue through the categories its cue
sheet puts it in, not through the category of the episode's sound row.
The cue sheets of a story now carry them: each cue of cues.json lists the
category names of its sequence ("categories"), read from the ACB, so a
player can route a cue to the bus its sheet names.
cri.decode and cri.decode_acb_bytes take `categories` for this; the story
export sets it. Cue sheets of other exports keep their cues.json.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The volume of a CRI category reaches a cue through the categories its cue sheet puts it in. A story's
cues.jsonnow lists them per cue (categories, e.g.["Voice", "VoiceConfig"]), read from the command list of the cue's sequence in the ACB (acb.cue_categories). A cue without any has no key.cri.decodeandcri.decode_acb_bytestakecategories(default off); the story export sets it. Cue sheets of other exports keep theircues.json.streams.jsonis unchanged.tests/formats/test_acb_categories.pyon a synthetic ACB;docs/commands.mdlists the field.Checked on the cue sheet
adv_voice_linkstory_raika_miku_10579: 38 of 38 cues listVoiceandVoiceConfig.🤖 Generated with Claude Code