Repository navigation
build: check the core and source layers in pyright's strict mode - #47
Merged
Merged
Conversation
pyproject.toml lists core, source and schemas as strict paths; the rest of the package stays in basic mode. The modules of these layers are fully annotated: - addressables: catalog locations are typed as `Location` records; `relative_path` takes and returns strings. - catalog and jp: the JP source and client are typed, and `jp.open_catalog` documents what it opens. - config and configfile: setting values are strings or lists of strings (`configfile.Value`); the prompt takes typed callables. - cache: the settings are a `Settings` typed dictionary and buckets store `(value, size)` pairs. - jsonio: `is_object` and `is_array` narrow decoded JSON values. - master: `download` takes a typed fetch function. Leaving an ApkSet's `with` block returns None: the archives it closes never suppress an error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core,sourceandschemasare type-checked in pyright's strict mode ([tool.pyright] strictinpyproject.toml); the other subpackages stay in basic mode.configfile.Value), cache settings (cache.Settings) and master downloads.core.jsonio.is_object/is_arraynarrow decoded JSON values.Checks
pyright: 0 errors (strict over core/source/schemas, basic elsewhere)ruff check .,ruff format --check .,lint-importspytest: all passmkdocs build --strict