Repository navigation
feat(music-data): publish the recommendation engine in the replay manifest - #20
Merged
Merged
Conversation
…ifest `nnnotes music-data --recommend-engine DIR` copies a wasm-bindgen `--target web` package of the deck model's `wasm/recommend` (`ournotes_recommend.js`, `ournotes_recommend_bg.wasm`, `build.json`) into the replay bundle beside the replay engine. Its `build.json` (`ournotes.recommend-engine/1`) must name the pinned model commit and the SHA-256 of both files, else the export stops before writing anything. The replay manifest lists it as `recommendEngine`: the model identity and the `js`, `wasm` and `build` resources with their URL relative to the manifest, SHA-256 and size. The model is the one of `engine` and of `deck-data.json`, so a page loads the recommendation module and the deck data it reads from one model commit and one master snapshot. Without the option the key is absent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nnnotes music-data --recommend-engine DIRcopies a wasm-bindgen--target webpackage of the deck model'swasm/recommend(
ournotes_recommend.js,ournotes_recommend_bg.wasm,build.json)into the replay bundle beside the replay engine. Its
build.json(
ournotes.recommend-engine/1) must name the pinned model commit and theSHA-256 of both files, else the export stops before writing anything.
The replay manifest lists it as
recommendEngine: the model identity andthe
js,wasmandbuildresources with their URL relative to themanifest, SHA-256 and size. The model is the one of
engineand ofdeck-data.json, so a page loads the recommendation module and the deckdata it reads from one model commit and one master snapshot. Without the
option the key is absent.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com