Repository navigation
docs(evals): agent eval of the ui-development reshape (#212, #213) - #220
Draft
georgewrmarshall wants to merge 2 commits into
Draft
georgewrmarshall wants to merge 2 commits into
georgewrmarshall wants to merge 2 commits into
Conversation
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
… and #213 Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds two agent-driven evaluations of the reshaped
ui/ui-developmentskills in:Files:
docs/evals/ui-development-reshape-2026-11-05.md: the first run, against docs(ui): reshape ui-development for Mobile — shared MCP-free base, thin overlay, no pinned inventory #212 @2d1ba46and docs(ui): reshape ui-development for Extension — shared MCP-free base, thin overlay, no Storybook MCP requirement #213 @9c57432. It logged 13 issues: 3 major, 7 minor, 3 notes, and no blockers.docs/evals/ui-development-reshape-2026-11-05-rerun.md: the same method, re-run after the actionable ISS fixes were applied, against docs(ui): reshape ui-development for Mobile — shared MCP-free base, thin overlay, no pinned inventory #212 @02bb1c2and docs(ui): reshape ui-development for Extension — shared MCP-free base, thin overlay, no Storybook MCP requirement #213 @a46f691.Method, for both runs: each PR's skills are installed into clones of
metamask-mobileandmetamask-extensionmain. Four scenarios run on each platform with Storybook MCP and Context Forge treated as unavailable: types win over manifest, restyle with foundations,Legacy*migration, and review checklist. Installed types come from the npm tarballs at the consumers' lockfile pins. For the re-run those were RN 0.55.0 and React 0.51.0, because Extension bumped its MMDS packages in metamask-extension#47305 between the two runs.Results:
Issue status after the re-run:
This PR only adds eval docs. The skill fixes themselves live on the #212 and #213 branches.
Type of Change
Checklist
Testing
./tools/install --repo <consumer> --domain uifrom each PR head. Both exited 0, and every relative link in the installedSKILL.mdresolves.maininto separate consumers for an A/B comparison, and installed each PR alone on the other platform to check for cross-PR effects.mainin both orders. Both are conflict-free.yarn test(76/76) andyarn lintpass on this branch.Additional Context
The first run read the Notion Design Brain through the Notion MCP, read-only. The re-run made no Notion or Design Brain changes.