Repository navigation
chore: bump snaps solana@7.0.0 tron@4.0.0 bitcoin@3.1.0 - #46807
Merged
Merged
Conversation
taran-a
added
the
no-changelog
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Builds ready [7480730]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 4 warn · 🔴 2 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [6ef32e7]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
taran-a
force-pushed
the
chore/bump-solana-tron-bitcoin-snaps
branch
from
September 30, 2026 11:02
6ef32e7 to
f291b7c
Compare
taran-a
marked this pull request as ready for review
September 30, 2026 11:03
Contributor
Builds ready [f291b7c]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 5 warn · 🔴 2 fail)
Bundle Size Diffs
|
taran-a
force-pushed
the
chore/bump-solana-tron-bitcoin-snaps
branch
from
September 30, 2026 12:45
f291b7c to
bb1e1b0
Compare
Contributor
Builds ready [bb1e1b0]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
taran-a
force-pushed
the
chore/bump-solana-tron-bitcoin-snaps
branch
from
September 30, 2026 13:39
bb1e1b0 to
0434f00
Compare
Contributor
|
Ci relaunched. |
Battambang
previously approved these changes
Oct 8, 2026
Mrtenz
reviewed
Oct 8, 2026
| assert.strictEqual( | ||
| parsedTransactionResult.signature, | ||
| 'TE42WbnNvycJGiEVxVV7gjZ3wnCHvZAWFcA2b8rnvp2SZQoQQwirTbTfNBiZWHnzzkg38AayUob29w7eFD3SVGj', | ||
| 'qyEFmpyDqeqiRHcEJXrb3Z1brwMadm4hLDzxDkCFF7ktPcPF7khxf8chzWHSdKzd95TPcY5BDHdX8z6GMutzpdm', |
Contributor
There was a problem hiding this comment.
@Mrtenz Putting the hash of the main is failing these 2 tests:
https://github.com/MetaMask/metamask-extension/actions/runs/37772205770/job/113297011073?pr=46807
https://github.com/MetaMask/metamask-extension/actions/runs/37772205770/job/113296886055?pr=46807
Member
There was a problem hiding this comment.
May be due to this breaking fix: MetaMask/internal-snaps#156
Turns out we were manipulating message bytes before signing, instead of singing them as-is. That would also change the expected signature bytes
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
In behind, the need to change the hash is due to this PR in this Solana release: MetaMask/internal-snaps#156
The signature is computed by the snap over the transaction message bytes and any change to those bytes changes the signature. In @metamask/solana-wallet-snap@7.0.0 the changelog lists:
BREAKING: Preserve dapp-origin signTransaction and signAndSendTransaction payloads by signing the decoded transaction directly (#156)
Contributor
Builds ready [21e2cb6]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 0 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
Mrtenz
previously approved these changes
Oct 8, 2026
mikesposito
previously approved these changes
Oct 8, 2026
Battambang
force-pushed
the
chore/bump-solana-tron-bitcoin-snaps
branch
from
October 8, 2026 12:55
21e2cb6 to
c3efb9d
Compare
Contributor
✨ Files requiring CODEOWNER review ✨🫰 @MetaMask/core-platform (1 files, +1 -1)
|
Contributor
|
I am removing the last commit that reverting to the hash of main branch for the Walletinvoke e2e and keeping the original last commit of this PR |
Battambang
approved these changes
Oct 8, 2026
Contributor
Builds ready [c3efb9d] [reused from 21e2cb6]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 0 warn · 🔴 3 fail)
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
|
|
mikesposito
approved these changes
Oct 8, 2026
Mrtenz
approved these changes
Oct 8, 2026
metamaskbot
added
the
release-13.53.0
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tron release changelog v4.0.0
Added
signProofOfOwnershipBatchfor signing multiple proof-of-ownership messages in one request. (#265)Transaction Added,Transaction Approved, andTransaction RejectedforsignTransactionconfirmations (#333)Changed
@metamask/keyring-apifrom^23.7.0to^24.1.0(#214)@metamask/keyring-snap-sdkfrom^9.2.1to^10.0.0(#214)@metamask/snaps-sdkfrom^11.2.0to^12.0.1(#214)Removed
assetcluster of handlers:onAssetHistoricalPrice,onAssetsConversion,onAssetsLookupandonAssetsMarketData(#263)Fixed
Transaction Submittedfrom the Wallet StandardsignAndSendTransactionpath so its transactions no longer reachTransaction Finalizedwithout a matching submit event (#343)Solana release changelog v7.0.0
Added
signProofOfOwnershipBatchfor signing multiple proof-of-ownership messages in one request. (#256)endowment:assetspermission for the Solana scopes to the snap manifest, with no-oponAssetsLookup,onAssetsConversion,onAssetHistoricalPrice, andonAssetsMarketDataentry points required to keep the permission (#274)Changed
@solana/kitfrom^6.9.0to^8.3.0and the@solana-program/*clients (compute-budget^0.18.1,system^0.14.1,token^0.16.1,token-2022^0.17.0) to their Kit 8-compatible versions. (#303)@metamask/keyring-apifrom^23.7.0to^24.1.0(#214)@metamask/keyring-snap-sdkfrom^9.2.1to^10.0.0(#214)@metamask/snaps-sdkfrom^11.2.0to^12.0.1(#214)snap_getBip32Entropycalls increateAccountsfrom two to one forbip44:discoverby deriving the activity-check address locally from the already-fetched coin-type node, and parallelize the entropy fetch with the existing-accounts state read for all creation paths (#304)AccountsSynchronizer.synchronizecalls for the same account set so duplicate in-flight syncs (e.g. simultaneous connection-recovery events across mainnet and devnet) share one run instead of fanning out redundant asset and transaction fetches (#304)trackErrorandwithCatchAndThrowSnapErrorto@metamask/snap-networks-utilscreateSnapErrorHandling, and addgetSnapProviderfor Snap RPC accessSnapAssetsAdapter;AssetsServiceis a thin facade that delegates metadata, market data, fetch, persist, and account asset reads through the adapter (no Core routing yet). (#121)AssetsServiceread API withsnap-networks-utils/ AssetsController shapes by addinggetAccountAssetByID,getAccountAssetsByIDs,getAccountAssetsByScope, andgetAccountAssets, and routing Keyring and Send through them (still Snap-owned storage). (#120)@metamask/utilsfrom^11.9.0to^11.11.9(#161)Removed
onAssetsLookup,onAssetsConversion,onAssetHistoricalPrice, andonAssetsMarketDataasset handler entry points, along with the now-unused handler modules and theendowment:assetspermission (#261)AssetsService.fetchAssetsMarketDataandSnapAssetsAdapter.fetchAssetsMarketData, theTokenPricesServiceclass, andPriceApiClient.getHistoricalPrices, all of which were only used by the removed asset handlers (#261)PriceApiClient.getFiatExchangeRatesmethod and relatedExchangeRatetype, the unusedtokenPricesunencrypted state field, the unusedfiatExchangeRatesandhistoricalPricesprice API cache TTL options, and unused price API test mocks (#261)Fixed
signTransactionandsignAndSendTransactionpayloads by signing the decoded transaction directly (#156)added by the API no longer fail validation (#321)
AccountTransactionsUpdatedkeyring event with a pendingunconfirmedtransaction immediately after broadcasting.Bitcoin release changelog v3.1.0
Added
signProofOfOwnershipBatchfor signing multiple proof-of-ownership messages in one request. (#266)Transaction Added,Transaction Approved, andTransaction Rejectedtracking events from Bitcoin transaction confirmations (#328, #329)Fixed
fromaddress of receive transactions by resolving the addresses that funded them through the chain indexer. Bitcoin inputs only reference a previous outpoint, so the sender was previously left empty. (#372)Changelog
CHANGELOG entry: null
Related issues
n/a
Manual testing steps
n/a
Screenshots/Recordings
Before
n/a
After
n/a
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Major Solana and Tron snap upgrades can change signing, sync, and keyring behavior in production multichain flows; extension code changes are limited to dependency versions and e2e mocks.
Overview
Bumps bundled multichain wallet Snaps: Solana
5.0.1→7.0.0, Tron3.2.0→4.0.0, and Bitcoin3.0.0→3.1.0, with matchingyarn.lockupdates.E2E tests are adjusted for the new Solana snap behavior: the multichain
wallet_invokeMethodsignAndSendTransaction assertion uses an updated expected transaction signature, and the SPL token send success mocks swapmockGetTokenAccountBalanceformockGetSuccessSignaturesForAddressafter broadcast so activity/history RPC expectations align with v7.Reviewed by Cursor Bugbot for commit c3efb9d. Bugbot is set up for automated code reviews on this repo. Configure here.