Repository navigation
Conversation
20949ec to
5c7844e
Compare
5c7844e to
aaf1197
Compare
2d2598a to
0114758
Compare
mikesposito
left a comment
There was a problem hiding this comment.
Have you considered implementing this in @metamask/snap-networks-utils (or all the function we can share at least) instead of the Solana Snap, so we can reuse them 1:1 for other Snaps?
There was a problem hiding this comment.
Why are we adding EN messages to non-EN locales? 🤔
There was a problem hiding this comment.
in solana when there is a missing key in locale we return that key as a message.
I actually have just removed my changes to unused locales - we use only en, es no.
but for es I thought its our approach that we add en as I found several already were there.
I have another PR in this stack with some UI components, maybe later I will see some candidates to move into the shared lib, but not it hard to decide |
f0d2f31 to
b38e90e
Compare
|



Explanation
Aligns the Solana snap's transaction confirmation with the shared transaction warning contract (Stellar/EVM reference behaviour / warn path), adopting the new shared components from
snap-networks-utils:useSecurityAlerts; scan-failure banners stay active while any scan preference is onsimulation+validation) and also run when only security alerts are enabledReferences
Checklist