Add input currency mode to Unified SwapBridge metrics#8909
Open
bfullam wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a3d4476. Configure here.
| ...(eventName === UnifiedSwapBridgeEventName.Completed && { | ||
| input_currency_mode: | ||
| historyItem.inputCurrencyMode ?? InputCurrencyMode.CRYPTO, | ||
| }), |
There was a problem hiding this comment.
Post-submission Failed events inconsistently omit input_currency_mode
Medium Severity
The input_currency_mode field is read from the history item only when eventName === Completed, but not when it's Failed. Pre-submission Failed events receive it via preConfirmationProperties, but post-submission Failed events (from polling status checks or #onTransactionFailed) go through #trackUnifiedSwapBridgeEvent without it. This creates inconsistent analytics data for the same event type — some Failed events include input_currency_mode and others don't, depending on when the failure occurred, even though inputCurrencyMode is persisted on the history item and available.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit a3d4476. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
input_currency_modeto Unified SwapBridge quote, submit, and completion metrics.InputCurrencyModeenum in@metamask/bridge-controllerwithfiatandcryptovalues.cryptofor backward compatibility.input_currency_modewithout local casts.Testing
@metamask/bridge-controllerand@metamask/bridge-status-controllerwith coverage disabled.Note
Low Risk
Analytics-only field additions with safe defaults; no changes to swap/bridge execution or auth.
Overview
Adds
input_currency_mode(fiat|crypto) to Unified SwapBridge analytics so clients can report whether the user entered the source amount in fiat or crypto.@metamask/bridge-controllerintroduces sharedInputCurrencyMode, exports it, and extends metrics types (includingInputChangedwithinput_currency_mode).BridgeControllerreads the mode from client event context and attaches it to Quotes Requested and Quotes Received, defaulting tocryptowhen omitted.@metamask/bridge-status-controllerthreads the mode from quote context through submit/intent flows, persists it on bridge history, includes it on pre-submit metrics viagetPreConfirmationPropertiesFromQuote, and emits it on Completed from stored history (again defaulting tocrypto).Test snapshots and changelogs are updated for the new payload field.
Reviewed by Cursor Bugbot for commit b3fdad6. Bugbot is set up for automated code reviews on this repo. Configure here.