stop unknown fileOp error logs for rename messages, noticed in #1770 - #1771
Open
reidsunderland wants to merge 2 commits into
Open
stop unknown fileOp error logs for rename messages, noticed in #1770#1771reidsunderland wants to merge 2 commits into
reidsunderland wants to merge 2 commits into
Conversation
Test Results360 tests 359 ✅ 1m 43s ⏱️ Results for commit d5d750b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an sr3 rename fileOp message is converted to v2, an error message will be logged saying
unknown fileOp, but that's not true. There's a separateifto handle renames, but it's not part of the if/elif/else logic because you can have sr3 messages that combine e.g. link and rename fileOps.