Mail fetch (poll + download) plugin modernization - #1767
Merged
Conversation
Test Results360 tests 359 ✅ 1m 47s ⏱️ Results for commit bd96feb. |
reidsunderland
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various fixes to the
poll/mail.pyanddownload/mail_ingest.pyplugins. All tested on development servers and eventually migrated to operational servers from our internal plugin repository.@reidsunderland suggested adding the checksum when polling the file so we don't need
nodupe_basis nameto prevent double posts. However, there doesn't seem to be a clear and obvious way to get this value without hashing the checksum from the raw data in the poll plugin. The download plugin also already fetches the checksum from the downloaded file.